-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BYOC][ETHOSN] Fix tests for new module API #6560
Conversation
Some of the downstream variants of our tests had been broken by a recent change to the API of build. This both fixes that and refactors a couple of tests so that they will run entirely in upstream CI and we won't see this sort of failure again. Change-Id: I841266eef0e2e89cc76e0526fc6cd3fc8d1326d8
Change-Id: Ie41c6d2c13c4473ecaa5c50c33d2c1589c742796
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look fine to me overall. However, I cannot verify the correctness of most changes due to the lack of test environment.
@u99127 @manupa-arm it would be great if you could review and approve explicitly.
cc @Leo-arm could you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment/question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo manupa-arm's comment.
Change-Id: I2c8bde44278e4cbc9cea5c5cbd4bb3c316ec37ae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment to add some description, otherwise this is good :)
LGTM |
Thanks @mbaret @manupa-arm @Leo-arm |
* [BYOC][ETHOSN] Fix tests for new module API Some of the downstream variants of our tests had been broken by a recent change to the API of build. This both fixes that and refactors a couple of tests so that they will run entirely in upstream CI and we won't see this sort of failure again. Change-Id: I841266eef0e2e89cc76e0526fc6cd3fc8d1326d8 * Only run mobilenet Change-Id: Ie41c6d2c13c4473ecaa5c50c33d2c1589c742796 * Improve docs Change-Id: I2c8bde44278e4cbc9cea5c5cbd4bb3c316ec37ae * More docs Change-Id: Ia9973915eecea647689535cc1e6eef9228111324
* [BYOC][ETHOSN] Fix tests for new module API Some of the downstream variants of our tests had been broken by a recent change to the API of build. This both fixes that and refactors a couple of tests so that they will run entirely in upstream CI and we won't see this sort of failure again. Change-Id: I841266eef0e2e89cc76e0526fc6cd3fc8d1326d8 * Only run mobilenet Change-Id: Ie41c6d2c13c4473ecaa5c50c33d2c1589c742796 * Improve docs Change-Id: I2c8bde44278e4cbc9cea5c5cbd4bb3c316ec37ae * More docs Change-Id: Ia9973915eecea647689535cc1e6eef9228111324
* [BYOC][ETHOSN] Fix tests for new module API Some of the downstream variants of our tests had been broken by a recent change to the API of build. This both fixes that and refactors a couple of tests so that they will run entirely in upstream CI and we won't see this sort of failure again. Change-Id: I841266eef0e2e89cc76e0526fc6cd3fc8d1326d8 * Only run mobilenet Change-Id: Ie41c6d2c13c4473ecaa5c50c33d2c1589c742796 * Improve docs Change-Id: I2c8bde44278e4cbc9cea5c5cbd4bb3c316ec37ae * More docs Change-Id: Ia9973915eecea647689535cc1e6eef9228111324
* [BYOC][ETHOSN] Fix tests for new module API Some of the downstream variants of our tests had been broken by a recent change to the API of build. This both fixes that and refactors a couple of tests so that they will run entirely in upstream CI and we won't see this sort of failure again. Change-Id: I841266eef0e2e89cc76e0526fc6cd3fc8d1326d8 * Only run mobilenet Change-Id: Ie41c6d2c13c4473ecaa5c50c33d2c1589c742796 * Improve docs Change-Id: I2c8bde44278e4cbc9cea5c5cbd4bb3c316ec37ae * More docs Change-Id: Ia9973915eecea647689535cc1e6eef9228111324
* [BYOC][ETHOSN] Fix tests for new module API Some of the downstream variants of our tests had been broken by a recent change to the API of build. This both fixes that and refactors a couple of tests so that they will run entirely in upstream CI and we won't see this sort of failure again. Change-Id: I841266eef0e2e89cc76e0526fc6cd3fc8d1326d8 * Only run mobilenet Change-Id: Ie41c6d2c13c4473ecaa5c50c33d2c1589c742796 * Improve docs Change-Id: I2c8bde44278e4cbc9cea5c5cbd4bb3c316ec37ae * More docs Change-Id: Ia9973915eecea647689535cc1e6eef9228111324
* [BYOC][ETHOSN] Fix tests for new module API Some of the downstream variants of our tests had been broken by a recent change to the API of build. This both fixes that and refactors a couple of tests so that they will run entirely in upstream CI and we won't see this sort of failure again. Change-Id: I841266eef0e2e89cc76e0526fc6cd3fc8d1326d8 * Only run mobilenet Change-Id: Ie41c6d2c13c4473ecaa5c50c33d2c1589c742796 * Improve docs Change-Id: I2c8bde44278e4cbc9cea5c5cbd4bb3c316ec37ae * More docs Change-Id: Ia9973915eecea647689535cc1e6eef9228111324
Some of the downstream variants of our tests had been broken by a recent change to the API of build. This both fixes that and refactors a couple of tests so that they will run entirely in upstream CI and we won't see this sort of failure again.