Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BYOC][ETHOSN] Fix tests for new module API #6560

Merged
merged 4 commits into from
Sep 30, 2020

Conversation

mbaret
Copy link
Contributor

@mbaret mbaret commented Sep 25, 2020

Some of the downstream variants of our tests had been broken by a recent change to the API of build. This both fixes that and refactors a couple of tests so that they will run entirely in upstream CI and we won't see this sort of failure again.

Some of the downstream variants of our tests had
been broken by a recent change to the API of build.
This both fixes that and refactors a couple of tests
so that they will run entirely in upstream CI and
we won't see this sort of failure again.

Change-Id: I841266eef0e2e89cc76e0526fc6cd3fc8d1326d8
Change-Id: Ie41c6d2c13c4473ecaa5c50c33d2c1589c742796
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine to me overall. However, I cannot verify the correctness of most changes due to the lack of test environment.

@u99127 @manupa-arm it would be great if you could review and approve explicitly.

@mbaret
Copy link
Contributor Author

mbaret commented Sep 28, 2020

cc @Leo-arm could you take a look?

Copy link
Contributor

@manupak manupak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment/question.

Copy link
Contributor

@Leo-arm Leo-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo manupa-arm's comment.

Change-Id: I2c8bde44278e4cbc9cea5c5cbd4bb3c316ec37ae
Copy link
Contributor

@manupak manupak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment to add some description, otherwise this is good :)

Change-Id: Ia9973915eecea647689535cc1e6eef9228111324
@manupak
Copy link
Contributor

manupak commented Sep 30, 2020

LGTM

@comaniac comaniac merged commit 2cfbd09 into apache:master Sep 30, 2020
@comaniac
Copy link
Contributor

Thanks @mbaret @manupa-arm @Leo-arm

TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 13, 2020
* [BYOC][ETHOSN] Fix tests for new module API

Some of the downstream variants of our tests had
been broken by a recent change to the API of build.
This both fixes that and refactors a couple of tests
so that they will run entirely in upstream CI and
we won't see this sort of failure again.

Change-Id: I841266eef0e2e89cc76e0526fc6cd3fc8d1326d8

* Only run mobilenet

Change-Id: Ie41c6d2c13c4473ecaa5c50c33d2c1589c742796

* Improve docs

Change-Id: I2c8bde44278e4cbc9cea5c5cbd4bb3c316ec37ae

* More docs

Change-Id: Ia9973915eecea647689535cc1e6eef9228111324
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 14, 2020
* [BYOC][ETHOSN] Fix tests for new module API

Some of the downstream variants of our tests had
been broken by a recent change to the API of build.
This both fixes that and refactors a couple of tests
so that they will run entirely in upstream CI and
we won't see this sort of failure again.

Change-Id: I841266eef0e2e89cc76e0526fc6cd3fc8d1326d8

* Only run mobilenet

Change-Id: Ie41c6d2c13c4473ecaa5c50c33d2c1589c742796

* Improve docs

Change-Id: I2c8bde44278e4cbc9cea5c5cbd4bb3c316ec37ae

* More docs

Change-Id: Ia9973915eecea647689535cc1e6eef9228111324
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 15, 2020
* [BYOC][ETHOSN] Fix tests for new module API

Some of the downstream variants of our tests had
been broken by a recent change to the API of build.
This both fixes that and refactors a couple of tests
so that they will run entirely in upstream CI and
we won't see this sort of failure again.

Change-Id: I841266eef0e2e89cc76e0526fc6cd3fc8d1326d8

* Only run mobilenet

Change-Id: Ie41c6d2c13c4473ecaa5c50c33d2c1589c742796

* Improve docs

Change-Id: I2c8bde44278e4cbc9cea5c5cbd4bb3c316ec37ae

* More docs

Change-Id: Ia9973915eecea647689535cc1e6eef9228111324
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 15, 2020
* [BYOC][ETHOSN] Fix tests for new module API

Some of the downstream variants of our tests had
been broken by a recent change to the API of build.
This both fixes that and refactors a couple of tests
so that they will run entirely in upstream CI and
we won't see this sort of failure again.

Change-Id: I841266eef0e2e89cc76e0526fc6cd3fc8d1326d8

* Only run mobilenet

Change-Id: Ie41c6d2c13c4473ecaa5c50c33d2c1589c742796

* Improve docs

Change-Id: I2c8bde44278e4cbc9cea5c5cbd4bb3c316ec37ae

* More docs

Change-Id: Ia9973915eecea647689535cc1e6eef9228111324
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 16, 2020
* [BYOC][ETHOSN] Fix tests for new module API

Some of the downstream variants of our tests had
been broken by a recent change to the API of build.
This both fixes that and refactors a couple of tests
so that they will run entirely in upstream CI and
we won't see this sort of failure again.

Change-Id: I841266eef0e2e89cc76e0526fc6cd3fc8d1326d8

* Only run mobilenet

Change-Id: Ie41c6d2c13c4473ecaa5c50c33d2c1589c742796

* Improve docs

Change-Id: I2c8bde44278e4cbc9cea5c5cbd4bb3c316ec37ae

* More docs

Change-Id: Ia9973915eecea647689535cc1e6eef9228111324
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Oct 19, 2020
* [BYOC][ETHOSN] Fix tests for new module API

Some of the downstream variants of our tests had
been broken by a recent change to the API of build.
This both fixes that and refactors a couple of tests
so that they will run entirely in upstream CI and
we won't see this sort of failure again.

Change-Id: I841266eef0e2e89cc76e0526fc6cd3fc8d1326d8

* Only run mobilenet

Change-Id: Ie41c6d2c13c4473ecaa5c50c33d2c1589c742796

* Improve docs

Change-Id: I2c8bde44278e4cbc9cea5c5cbd4bb3c316ec37ae

* More docs

Change-Id: Ia9973915eecea647689535cc1e6eef9228111324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants