[Improvement] Replace putIfAbsent with computeIfAbsent in some critical paths #493
Closed
2 of 3 tasks
Assignees
Labels
good first issue
Good for newcomers
Comments
|
#519 these two issues should be considered together |
|
is this issue resolved? |
|
Hi @zuston I'd like to handle this issue if you agreed. Thank you. |
|
@cchung100m Assigned. Thanks in advance |
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
May 11, 2023
… some critical paths
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
May 12, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
May 12, 2023
zuston
pushed a commit
that referenced
this issue
May 13, 2023
…void performance loss in some critical paths (#876) ### What changes were proposed in this pull request? Replace `putIfAbsent` with `computeIfAbsent` in some critical paths ### Why are the changes needed? Fix: #493 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? current UT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code of Conduct
Search before asking
What would you like to be improved?
This problem is mentioned by previous PR #481 (comment).
The invoking of
putIfAbsentwill always call its value if it's a time-consuming operation. So we'd better replace putIfAbsent with computeIfAbsent in some critical paths.How should we improve?
No response
Are you willing to submit PR?
The text was updated successfully, but these errors were encountered: