Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-10094][agent] Fix the bug: the task record for data supplementation has not expired #10095

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

justinwwhuang
Copy link
Contributor

@justinwwhuang justinwwhuang commented Apr 28, 2024

Fixes #10094

Motivation

Fix the bug: the task record for data supplementation has not expired

Modifications

Put the logic of deleting expired records into OffsetManager for unified management

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

No doc needed

Copy link
Contributor

@aloyszhang aloyszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinwwhuang justinwwhuang merged commit fabb0c4 into apache:master Apr 29, 2024
8 checks passed
@justinwwhuang justinwwhuang deleted the b10094 branch April 29, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Agent] The task record for data supplementation has not expired
3 participants