Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-10319][Agent] Get audit Id from audit sdk #10322

Merged
merged 3 commits into from
May 30, 2024
Merged

[INLONG-10319][Agent] Get audit Id from audit sdk #10322

merged 3 commits into from
May 30, 2024

Conversation

justinwwhuang
Copy link
Contributor

@justinwwhuang justinwwhuang commented May 30, 2024 •
edited
Loading

Fixes #10319

Motivation

Get audit Id from audit sdk

Modifications

1、Get audit Id from audit sdk
2、Get metric id from audit sdk

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

No doc needed

@justinwwhuang justinwwhuang self-assigned this May 30, 2024
@justinwwhuang justinwwhuang added this to the 1.13.0 milestone May 30, 2024
doleyzi
doleyzi approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@doleyzi doleyzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinwwhuang justinwwhuang merged commit c689295 into apache:master May 30, 2024
8 checks passed
@justinwwhuang justinwwhuang deleted the b10319 branch May 30, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dockerzhang dockerzhang dockerzhang approved these changes

@doleyzi doleyzi doleyzi approved these changes

@aloyszhang aloyszhang aloyszhang approved these changes

Assignees

@justinwwhuang justinwwhuang

Labels
component/agent component/audit
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

[Improve][Agent] Agent should get audit id from audit sdk
4 participants
@justinwwhuang @dockerzhang @doleyzi @aloyszhang