[INLONG-10384][Agent] Add functions to the Store interface to extend new storage plugins #10385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtend new storage plugins
luchunliang
reviewed
Jun 11, 2024
inlong-agent/agent-core/src/main/java/org/apache/inlong/agent/core/task/TaskManager.java
Outdated
Show resolved
Hide resolved
justinwwhuang
changed the title
…new storage plugins
EMsnap
previously approved these changes
Jun 12, 2024
…new storage plugins
luchunliang
previously approved these changes
Jun 12, 2024
…new storage plugins
dockerzhang
approved these changes
Jun 12, 2024
aloyszhang
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10384
Motivation
Add functions to the Store interface which is used to store task, instance and offset info to extend new storage plugins
Modifications
1 add String getSplitter(): Different storage has different requirements for delimiters
2 add String getUniqueKey(): For remote storage, a unique identifier is needed to distinguish agents
3 add String replaceKeywords(String source): Different storage has different keyword restrictions
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation
No doc needed