Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-10443][Agent] Put Rocksdb into the plugins module #10444

Merged
merged 8 commits into from
Jun 19, 2024
Merged

[INLONG-10443][Agent] Put Rocksdb into the plugins module #10444

merged 8 commits into from
Jun 19, 2024

Conversation

justinwwhuang
Copy link
Contributor

@justinwwhuang justinwwhuang commented Jun 18, 2024 •
edited
Loading

Fixes #10443

Motivation

Place Rocksdb in the plugins module and adjust the relevant unit tests

Modifications

1 Place Rocksdb in the plugins module and adjust the relevant unit tests
2 Add storage type configuration instructions

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

No doc needed

@justinwwhuang justinwwhuang added this to the 1.13.0 milestone Jun 18, 2024
@justinwwhuang justinwwhuang self-assigned this Jun 18, 2024
dockerzhang
dockerzhang reviewed Jun 19, 2024
View reviewed changes
inlong-agent/conf/agent.properties Outdated Show resolved Hide resolved
inlong-agent/conf/agent.properties Outdated Show resolved Hide resolved
justinwwhuang and others added 2 commits June 19, 2024 12:42
@justinwwhuang @dockerzhang
Update inlong-agent/conf/agent.properties
ab7c6c3 
Co-authored-by: Charles Zhang <dockerzhang@apache.org>
@justinwwhuang @dockerzhang
Update inlong-agent/conf/agent.properties
b71b796 
Co-authored-by: Charles Zhang <dockerzhang@apache.org>
aloyszhang
aloyszhang previously approved these changes Jun 19, 2024
View reviewed changes
@dockerzhang dockerzhang merged commit 21ebfe5 into apache:master Jun 19, 2024
8 checks passed
@justinwwhuang justinwwhuang deleted the b10443 branch June 19, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EMsnap EMsnap EMsnap approved these changes

@dockerzhang dockerzhang dockerzhang approved these changes

@aloyszhang aloyszhang aloyszhang left review comments

@doleyzi doleyzi Awaiting requested review from doleyzi

Assignees

@justinwwhuang justinwwhuang

Labels
component/agent
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

[Improve][Agent] Put Rocksdb into the plugins module
4 participants
@justinwwhuang @dockerzhang @EMsnap @aloyszhang