Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-10287][Agent] Update the Redis Source #11084

Merged
merged 8 commits into from
Oct 8, 2024

Conversation

emptyOVO
Copy link
Contributor

Fixes #10287

Motivation

this pull request is a enhancement of the previous pr #10801
Complete the task requirement mentioned in pr #10801

  • Two modes are provided. One uses command and the other uses the subscription .
  • To select a command for subscription, you need to configure one more parameter is_subscribe
  • For cases where there are many keys, suggest to use a batch query interface like mget
  • For cases where there are many keys but still use the get command, use jedis.pipeline to reduce io costs
  • Limit the maximum size of a single piece of data, if the data size exceeds 500k , automatically skip and discard the data

Modifications

  • Modify TaskProfileDto and RedisTask to accept and parse the configuration.
  • Add RedisTask, RedisInstance, and RedisSource classes
  • Provide Unit Test

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

aloyszhang
aloyszhang previously approved these changes Sep 22, 2024
Copy link
Contributor

@justinwwhuang justinwwhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@luchunliang luchunliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dockerzhang dockerzhang merged commit cc82864 into apache:master Oct 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Agent] Update the Redis Source
5 participants