Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-10464][SDK] InlongSDK support retry sending when failed #11144

Merged
merged 6 commits into from
Oct 9, 2024

Conversation

emptyOVO
Copy link
Contributor

@emptyOVO emptyOVO commented Sep 19, 2024

Fixes #10464

Motivation

When InlongSDK fails to send data to DataProxy, it returns the failure to the user directly. Add the capability to retry sending.

  • Support choose another MessageSender to resend data when the send fails
  • Able to configure max retry times
  • Check failures and only retry those retriable, discard those not.

Modifications

  1. add sendSuccess variable marks sending status last time
  2. add methods retryWhenSendMessageFail retryWhenSendMessageIndexFail to send message, send message by itself first, if fail ,choose another node to retry, and ensure the node is retriable, discard those not
  3. add getRandomSuccessSender to choose retriable MessageSender in CACHE_SENDER

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@emptyOVO emptyOVO marked this pull request as draft September 23, 2024 13:00
@emptyOVO emptyOVO marked this pull request as ready for review September 25, 2024 14:07
@aloyszhang aloyszhang merged commit 00bb1d2 into apache:master Oct 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][SDK] InlongSDK support retry sending when failed
3 participants