-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INLONG-7792][Manager] Support export Excel template file of StreamSource #7793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a961821
to
461da66
Compare
healchow
approved these changes
Apr 6, 2023
vernedeng
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dockerzhang
approved these changes
Apr 7, 2023
fuweng11
reviewed
Apr 7, 2023
...-common/src/main/java/org/apache/inlong/manager/common/tool/excel/ExcelCellDataTransfer.java
Outdated
Show resolved
Hide resolved
...-common/src/main/java/org/apache/inlong/manager/common/tool/excel/ExcelCellDataTransfer.java
Outdated
Show resolved
Hide resolved
...ager/manager-common/src/main/java/org/apache/inlong/manager/common/tool/excel/ExcelTool.java
Outdated
Show resolved
Hide resolved
...ager/manager-common/src/main/java/org/apache/inlong/manager/common/tool/excel/ExcelTool.java
Outdated
Show resolved
Hide resolved
...ager/manager-common/src/main/java/org/apache/inlong/manager/common/tool/excel/ExcelTool.java
Outdated
Show resolved
Hide resolved
fuweng11
approved these changes
Apr 7, 2023
fuweng11
reviewed
Apr 7, 2023
...-common/src/main/java/org/apache/inlong/manager/common/tool/excel/ExcelCellDataTransfer.java
Outdated
Show resolved
Hide resolved
...ager/manager-common/src/main/java/org/apache/inlong/manager/common/tool/excel/ExcelTool.java
Outdated
Show resolved
Hide resolved
...ager/manager-common/src/main/java/org/apache/inlong/manager/common/tool/excel/ExcelTool.java
Outdated
Show resolved
Hide resolved
fuweng11
approved these changes
Apr 7, 2023
healchow
requested changes
Apr 7, 2023
...nager-web/src/main/java/org/apache/inlong/manager/web/controller/InlongStreamController.java
Show resolved
Hide resolved
...nager-web/src/main/java/org/apache/inlong/manager/web/controller/InlongStreamController.java
Show resolved
Hide resolved
healchow
approved these changes
Apr 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[INLONG-7792][Manager] Support parsing and exporting Excel files
Excel is one of the common office software formats for most enterprises. For InLong, it is very convenient to import and export batch information, such as batch operations of table fields, by supporting direct parsing of files.
Considering that there will be scenarios of importing and exporting Excel in the future, here we have only made a thin encapsulation on Apache POI to make it as universal as possible.
Validation Results