Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-8290][Manager] Add tenant info into each query by SQL interceptor #8304

Merged
merged 7 commits into from
Jun 26, 2023

Conversation

vernedeng
Copy link
Contributor

Prepare a Pull Request

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve?

Modifications

Describe the modifications you've done.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@vernedeng vernedeng self-assigned this Jun 21, 2023
@vernedeng vernedeng added this to the 1.8.0 milestone Jun 21, 2023
@vernedeng vernedeng requested review from fuweng11 and healchow June 21, 2023 08:16
@healchow
Copy link
Member

@vernedeng Please add more design detail in the PR comment, thanks.

@healchow healchow changed the title [INLONG-8290][Manager] Support sql interceptor to add tenant into each query [INLONG-8290][Manager] Add tenant info into each query by SQL interceptor Jun 21, 2023
@vernedeng
Copy link
Contributor Author

vernedeng commented Jun 26, 2023

@vernedeng Please add more design detail in the PR comment, thanks.

The main idea to achieve multiple tenant is to check the request permission in the web fitler #8201 , and add the target tenant at SQL preparation stage by annotating those queries. The developers just focus on the business logic, all current permission-related processes will be removed.

@healchow healchow merged commit d3d1a0b into apache:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Manager] Support SQL interceptor to add tenant into each query
4 participants