Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-8649][Agent] Fix the proxysink thread leaks when the dataproxy sdk init failed #8650

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

justinwwhuang
Copy link
Contributor

fix bug: proxysink thread leaks when the dataproxy sdk init failed

Prepare a Pull Request

Motivation

proxysink thread leaks when the dataproxy sdk init failed

Modifications

start the thread after the sender has manager start

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@dockerzhang dockerzhang changed the title [INLONG-8649][Agent]fix bug: proxysink thread leaks when the dataproxy sdk init failed [INLONG-8649][Agent] Fix the proxysink thread leaks when the dataproxy sdk init failed Aug 7, 2023
@dockerzhang dockerzhang merged commit 1ad696b into apache:master Aug 7, 2023
10 checks passed
@justinwwhuang justinwwhuang deleted the develop2 branch August 7, 2023 11:03
ZhaoNiuniu pushed a commit to ZhaoNiuniu/inlong that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Agent] Thread leaks for ProxySink when the DataProxy SDK init failed
4 participants