[INLONG-8392][Manager] Optimize the HeartbeatMsg class #9512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gosonzhang
previously approved these changes
Dec 22, 2023
dockerzhang
previously approved these changes
Dec 22, 2023
fuweng11
dismissed stale reviews from dockerzhang and gosonzhang
via
431e9bc
2 tasks
dockerzhang
previously approved these changes
Dec 22, 2023
gosonzhang
previously approved these changes
Dec 22, 2023
2 tasks
fuweng11
dismissed stale reviews from gosonzhang and dockerzhang
via
36c7e5d
gosonzhang
approved these changes
Dec 22, 2023
dockerzhang
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
Motivation
Optimize the HeartbeatMsg class.
Modifications
Optimize the HeartbeatMsg class.
1.Added differentiation of reported business types based on reporting source type parameters.
2.Due to the fact that dataproxy reports multiple IP addresses, ports, and other information, these information are no longer organized in the form of strings and commas, but are placed in a list object.
3.Dataproxy nodes add reporting types to distinguish which dataproxy node information will be pulled when SDK reports.