Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-9773][Manager] SortSdk configuration support acquire tenant from InlongGroup #9776

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

vernedeng
Copy link
Contributor

@vernedeng vernedeng commented Mar 5, 2024

Prepare a Pull Request

(Change the title refer to the following example)

  • Title Example: [INLONG-XYZ][Component] Title of the pull request

(The following XYZ should be replaced by the actual GitHub Issue number)

Motivation

To improve the compatibility, the tenant of InlongGroup in the inner pulsar should be acquire from both the InlongGroupInfo and InlongClusterInfo.

Modifications

Describe the modifications you've done.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@vernedeng vernedeng added this to the 1.12.0 milestone Mar 5, 2024
@vernedeng vernedeng self-assigned this Mar 5, 2024
luchunliang
luchunliang previously approved these changes Mar 5, 2024
fuweng11
fuweng11 previously approved these changes Mar 5, 2024
@vernedeng vernedeng dismissed stale reviews from fuweng11 and luchunliang via f4b7478 March 7, 2024 03:37
@dockerzhang dockerzhang merged commit 7c4adbf into apache:master Mar 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Manager] SortSdk configuration support acquire tenant from InlongGroup
5 participants