Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-9788][Sort] Supports data parse that contains delimiters in kv and csv data format #9789

Merged
merged 7 commits into from
Mar 10, 2024

Conversation

baomingyu
Copy link
Contributor

@aloyszhang aloyszhang added this to the 1.12.0 milestone Mar 8, 2024
@baomingyu
Copy link
Contributor Author

@aloyszhang
Copy link
Contributor

aloyszhang commented Mar 8, 2024

All existing tests are tests of data in kv and csv formats that combine expected rules. The new ones are scenarios that can parse data in kv and csv formats that do not comply with the rules.

What I am concerned about is whether the new test cases can be added to the existing UT class(the three UT classes mentioned above) or not.

Or, are there some reasons that we must put the new test cases into a new UT class?

@baomingyu
Copy link
Contributor Author

All existing tests are tests of data in kv and csv formats that combine expected rules. The new ones are scenarios that can parse data in kv and csv formats that do not comply with the rules.

What I am concerned about is whether the new test cases can be added to the existing UT class(the three UT classes mentioned above) or not.

Or, are there some reasons that we must put the new test cases into a new UT class?

New tests test new scenarios,whether to put it in the inventory will be adjusted later.

@aloyszhang
Copy link
Contributor

New tests test new scenarios,whether to put it in the inventory will be adjusted later.

Make sense to me. We can unify the UT later.

@dockerzhang dockerzhang merged commit 45e7afc into apache:master Mar 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Sort] Supports data parse that contains delimiters in kv and csv data content
4 participants