separate the synchronized block of AbstractCompactionEstimator file i…

…nfo cache (#12019)
apache · Feb 2, 2024 · 2f1dac5 · 2f1dac5
1 parent c8419ec
commit 2f1dac5
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/...b/storageengine/dataregion/compaction/selector/estimator/AbstractCompactionEstimator.java b/...b/storageengine/dataregion/compaction/selector/estimator/AbstractCompactionEstimator.java
@@ -94,13 +94,15 @@ private FileInfo getFileInfoFromCache(TsFileResource resource) throws IOExceptio
         fileInfoCache.put(resource, fileInfo);
         return fileInfo;
       }
-      try (TsFileSequenceReader reader =
-          new TsFileSequenceReader(resource.getTsFilePath(), true, false)) {
-        FileInfo fileInfo = CompactionEstimateUtils.calculateFileInfo(reader);
-        fileInfoCache.put(resource, fileInfo);
+    }
+    try (TsFileSequenceReader reader =
+        new TsFileSequenceReader(resource.getTsFilePath(), true, false)) {
+      FileInfo fileInfo = CompactionEstimateUtils.calculateFileInfo(reader);
+      fileInfoCache.put(resource, fileInfo);
+      synchronized (globalFileInfoCacheForFailedCompaction) {
         globalFileInfoCacheForFailedCompaction.put(file, fileInfo);
-        return fileInfo;
       }
+      return fileInfo;
     }
   }