You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Other than commented most of that test method, any ideas to work around/fix it?
(i'm not ruling out user error either)
Well... it's a TZ issue. I'm currently UTC -4, if I set my timezone to UTC or something +, the test seem to pass.
5097600000 in my TZ is Feb 28th, plus one month is March 28,
Using UTC, it's March 1st, plus one month is April 1st
Are you willing to submit a PR?
I'm willing to submit a PR!
The text was updated successfully, but these errors were encountered:
DateTimeUtilsTest.getConvertDurationIncludingMonthUnit() uses dates conversions that are TZ specfic.
Wrapping the test in a session, allows this single test to use a set timezone, while not affecting the behavior of other tests
Fixes: apache#12970
DateTimeUtilsTest.getConvertDurationIncludingMonthUnit() uses dates conversions that are TZ specfic.
Wrapping the test in a session, allows this single test to use a set timezone, while not affecting the behavior of other tests
Fixes: #12970
(cherry picked from commit b527e06)
Search before asking
Version
1.3.3-SNAPSHOT
Describe the bug and provide the minimal reproduce step
Set your timezone to
UTC-4
(or anythingUTC-*
probably), and run the tests...What did you expect to see?
Passing tests
What did you see instead?
failing tests
Anything else?
TL;DR: Adding a month to a date is problematic, depending on the TZ you are in.
Copied from slack:
I'm running the IoTDB UT's locally, (all the tests that are included in the default profiles, e.g. mvn clean install)
All the tests pass except one in DateTimeUtilsTest
https://ge.apache.org/s/rd4tbdzopz2ju/tests/goal/org.apache.iotdb:iotdb-server:sure[…]IncludingMonthUnit?expanded-stacktrace=WyIwIl0&top-execution=1
Other than commented most of that test method, any ideas to work around/fix it?
(i'm not ruling out user error either)
Well... it's a TZ issue. I'm currently UTC -4, if I set my timezone to UTC or something +, the test seem to pass.
5097600000 in my TZ is Feb 28th, plus one month is March 28,
Using UTC, it's March 1st, plus one month is April 1st
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: