Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] [Python] Allow for sqlalchemy versions greater tha 2.0 #13991

Open
2 tasks done
MarcBresson opened this issue Nov 4, 2024 · 5 comments · May be fixed by #14083
Open
2 tasks done

[Feature request] [Python] Allow for sqlalchemy versions greater tha 2.0 #13991

MarcBresson opened this issue Nov 4, 2024 · 5 comments · May be fixed by #14083

Comments

@MarcBresson
Copy link

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

New major version of sqlalchemy did not introduce any major breaking change and the python code here is probably already compatible. As a matter of fact, we are using sqlalchemy 2.0.27 with an older version of apache-iotdb that did not set such a hard condition on the requirements.

Solution

No response

Alternatives

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Hi, this is your first issue in IoTDB project. Thanks for your report. Welcome to join the community!

@CritasWang
Copy link
Collaborator

Welcome submit a PR

@MarcBresson MarcBresson linked a pull request Nov 13, 2024 that will close this issue
Open
11 tasks
@CritasWang
Copy link
Collaborator

CI failed and is incompatible in some scenarios

@MarcBresson
Copy link
Author

Hello @CritasWang my bad, tests were outdated compared to the examples given in the readme. Now tests should run just fine

@CritasWang
Copy link
Collaborator

Hello @CritasWang my bad, tests were outdated compared to the examples given in the readme. Now tests should run just fine

https://github.com/apache/iotdb/actions/runs/11910341559/job/33262355435?pr=14083
https://github.com/apache/iotdb/actions/runs/11910341559/job/33262354350?pr=14083

There are still some issues that require further modifications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove sqlalchemy upper version constraint for python client MarcBresson/iotdb
2 participants
@CritasWang @MarcBresson