Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture build scans on ge.apache.org to benefit from deep build insights #11243

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

clayburn
Copy link
Contributor

@clayburn clayburn commented Oct 8, 2023

@chrisdutz - It was nice to meet you at Community over Code today. This is the PR we discussed to publish Build Scans to ge.apache.org.

Description

This PR publishes a build scan for every CI build and for every local build from an authenticated Apache committer. The build will not fail if publishing fails.

The build scans of the Apache iotdb project are published to the Develocity instance at ge.apache.org, hosted by the Apache Software Foundation and run in partnership between the ASF and Gradle. This Develocity instance has all features and extensions enabled and is freely available for use by the Apache iotdb project and all other Apache projects.

On this Develocity instance, Apache iotdb will have access not only to all of the published build scans but other aggregate data features such as:

  • Dashboards to view all historical build scans, along with performance trends over time
  • Build failure analytics for enhanced investigation and diagnosis of build failures
  • Test failure analytics to better understand trends and causes around slow, failing, and flaky tests

Please let me know if there are any questions about the value of Develocity or the changes in this pull request and I’d be happy to address them.

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this is your first pull request in IoTDB project. Thanks for your contribution! IoTDB will be better because of you.

@chrisdutz
Copy link
Contributor

So mabe some additional information on this ... I learned at CommunityOverCode that we have a gradle-enterprise instance at Apache, which also is ale to enrich Maven builds. The probably most interesting thing is that with these extensions we should be able to detect which tests need to be run to test changed code of a commit and it allows running these first. I thought we could probably give that a try ... I probably need to check with Infra, how we can use this on our self-hosted runners though.

@clayburn
Copy link
Contributor Author

clayburn commented Oct 8, 2023

For what it's worth, the GE_ACCESS_TOKEN is an org-wide secret managed by ASF Infra. I know this is in place and available to use. GitHub Actions does not allow PRs from forks to access secrets, so you won't see any publishing from this PR.

I'm not a GitHub Actions expert, but I believe that secrets are propagated to self-hosted runners. If I remember correctly, this is how Apache Beam do it. Still a good conversation that we can have with Infra today to verify.

@chrisdutz chrisdutz merged commit e3c8643 into apache:master Oct 9, 2023
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants