Pipe: Move parsing event logic into PipeProcessorSubtask to separate CPU intensive and IO intensive tasks #11965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/task/subtask/processor/PipeProcessorSubtask.java
Caideyipi
suggested changes
Jan 31, 2024
...node/src/main/java/org/apache/iotdb/db/pipe/task/subtask/processor/PipeProcessorSubtask.java
Outdated
Show resolved
Hide resolved
SteveYurongSu
approved these changes
Feb 7, 2024
SteveYurongSu
changed the title
SzyWilliam
pushed a commit
to SzyWilliam/iotdb
that referenced
this pull request
Nov 26, 2024
…CPU intensive and IO intensive tasks (apache#11965) Co-authored-by: Caideyipi <87789683+Caideyipi@users.noreply.github.com> Co-authored-by: Steve Yurong Su <rong@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
PipeProcessorSubtask.PipeProcessorSubtaskto store parsed events.Note:
For memory control, parsed events are stored in two places:
PipeProcessorSubtask#parsedEventQueueandPipeEventCollector#bufferQueue. The former one will only store events parsed from one source event, andPipeProcessorSubtaskwill not parse new events if the latter one is not empty. So there won't be too much parsed events in queue..