New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipe: using clusterId to judge whether the target cluster is source cluster #11994

Merged

SteveYurongSu merged 24 commits into apache:master from xuanronaldo:TIMECHO-556

Feb 2, 2024

Contributor

xuanronaldo commented Jan 28, 2024 •

edited by SteveYurongSu

Loading

AS TITLE.

xuanronaldo added 2 commits

January 28, 2024 17:01


          update a new handshake request

694cd6e


          format code

7ac2296

SteveYurongSu self-assigned this

xuanronaldo added 5 commits

January 29, 2024 10:49


          1. rename the PipeTransferHandshakeReq to PipeTransferHandshakeV1Req.

248ae19

2. handle PipeTransferHandshakeV2Req


          handle PipeTransferHandshakeV2Req in sync connector

ff01ee9


          1. send PipeTransferHandshakeV2Req default in async connector

ab1419d

2. add UT testPipeValidateHandshakeV2Req.


          add PipeConstant class

b71d031


          format code

c4577c9

SteveYurongSu reviewed

View reviewed changes

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/runtime/PipeRuntimeAgent.java Outdated Show resolved Hide resolved

SteveYurongSu reviewed

View reviewed changes

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/runtime/PipeRuntimeAgent.java Outdated Show resolved Hide resolved

SteveYurongSu reviewed

View reviewed changes

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/common/PipeConstant.java Outdated Show resolved Hide resolved

SteveYurongSu reviewed

View reviewed changes

...e/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/airgap/IoTDBAirGapConnector.java Outdated Show resolved Hide resolved

SteveYurongSu reviewed

View reviewed changes

.../org/apache/iotdb/db/pipe/connector/protocol/thrift/async/IoTDBThriftAsyncClientManager.java Outdated Show resolved Hide resolved

SteveYurongSu reviewed

View reviewed changes

...va/org/apache/iotdb/db/pipe/connector/protocol/thrift/sync/IoTDBThriftSyncClientManager.java Outdated Show resolved Hide resolved

SteveYurongSu reviewed

View reviewed changes

...e/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/thrift/IoTDBThriftReceiverV1.java Show resolved Hide resolved

SteveYurongSu reviewed

View reviewed changes

...datanode/src/test/java/org/apache/iotdb/db/pipe/connector/PipeDataNodeThriftRequestTest.java Outdated Show resolved Hide resolved

SteveYurongSu requested changes

View reviewed changes

Member

SteveYurongSu left a comment

Plz check the comments

xuanronaldo added 3 commits

January 30, 2024 17:02


          fix problems of comments

2a91d77


          Merge branch 'master' of https://github.com/apache/iotdb into TIMECHO…

dbc53d2

…-556


          add apache rat in PipeTransferHandshakeV2Req

0c1d93c

Caideyipi suggested changes

View reviewed changes

Collaborator

Caideyipi left a comment

PTAL

.../src/main/java/org/apache/iotdb/db/pipe/connector/payload/evolvable/common/PipeConstant.java Outdated Show resolved Hide resolved

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/runtime/PipeRuntimeAgent.java Outdated Show resolved Hide resolved

...org/apache/iotdb/db/pipe/connector/payload/evolvable/request/PipeTransferHandshakeV2Req.java Outdated Show resolved Hide resolved

...va/org/apache/iotdb/db/pipe/connector/protocol/thrift/sync/IoTDBThriftSyncClientManager.java Outdated Show resolved Hide resolved

...e/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/thrift/IoTDBThriftReceiverV1.java Outdated Show resolved Hide resolved

xuanronaldo added 3 commits

January 31, 2024 16:01


          fix problems of comments.

288419d


          rename PipeConstant to PipeConnectorConstant

d975937


          format code

c3ef4aa

xuanronaldo requested review from SteveYurongSu and Caideyipi

January 31, 2024 08:08

SteveYurongSu added 2 commits

February 1, 2024 18:28


          Merge branch 'master' of https://github.com/apache/iotdb into pr/11994

4c04878

fix

1c3d981

Caideyipi reviewed

View reviewed changes

...va/org/apache/iotdb/db/pipe/connector/protocol/thrift/sync/IoTDBThriftSyncClientManager.java Outdated Show resolved Hide resolved

...ore/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/airgap/IoTDBAirGapReceiver.java Outdated Show resolved Hide resolved


          refactor

cb63937

SteveYurongSu added 5 commits

February 2, 2024 11:24


          RENAME

47edecf


          fix receiver

68c380b


          Update IoTDBThriftReceiverV1.java

4cb7011


          Update IoTDBThriftSyncClientManager.java

f9a1d71


          Update IoTDBThriftAsyncClientManager.java

f5f79f8

SteveYurongSu reviewed

View reviewed changes

...e/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/airgap/IoTDBAirGapConnector.java Outdated Show resolved Hide resolved

SteveYurongSu added 3 commits

February 2, 2024 13:03


          Update IoTDBAirGapConnector.java

d6db5f1


          refactor

075f8bc


          Update PipeTransferHandshakeV2Req.java

7efd38f

SteveYurongSu approved these changes

View reviewed changes

SteveYurongSu changed the title ~~Pipe: using clusterId to judge whether the target cluster is source cluster.~~ Pipe: using clusterId to judge whether the target cluster is source cluster

This comment was marked as abuse.

Sign in to view

SteveYurongSu merged commit 4230ad1 into apache:master

35 of 36 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet