Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate the synchronized block of AbstractCompactionEstimator file info cache #12019

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Separate the synchronized block of AbstractCompactionEstimator file info cache #12019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions ...b/storageengine/dataregion/compaction/selector/estimator/AbstractCompactionEstimator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,15 @@ private FileInfo getFileInfoFromCache(TsFileResource resource) throws IOExceptio
fileInfoCache.put(resource, fileInfo);
return fileInfo;
}
try (TsFileSequenceReader reader =
new TsFileSequenceReader(resource.getTsFilePath(), true, false)) {
FileInfo fileInfo = CompactionEstimateUtils.calculateFileInfo(reader);
fileInfoCache.put(resource, fileInfo);
}
try (TsFileSequenceReader reader =
new TsFileSequenceReader(resource.getTsFilePath(), true, false)) {
FileInfo fileInfo = CompactionEstimateUtils.calculateFileInfo(reader);
fileInfoCache.put(resource, fileInfo);
synchronized (globalFileInfoCacheForFailedCompaction) {
globalFileInfoCacheForFailedCompaction.put(file, fileInfo);
return fileInfo;
}
return fileInfo;
}
}

Expand Down
Loading