Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOTDB-6296] Fix memory leak in MQTTService #12046

Merged
merged 1 commit into from
Feb 19, 2024
Merged

[IOTDB-6296] Fix memory leak in MQTTService #12046

merged 1 commit into from
Feb 19, 2024

Conversation

JackieTien97
Copy link
Contributor

@JackieTien97 JackieTien97 commented Feb 19, 2024

image

As we can see in the interface java doc: The receiver MUST release the payload of the message, either by calling super.onPublish, or by calling msg.getPayload.release() directly., otherwise the memory will leak.

we use MQTTClient in example/mqtt/src/main/java/org/apache/iotdb/mqtt, changes like:

/*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
 * to you under the Apache License, Version 2.0 (the
 * "License"); you may not use this file except in compliance
 * with the License.  You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package org.apache.iotdb.mqtt;

import org.fusesource.mqtt.client.BlockingConnection;
import org.fusesource.mqtt.client.MQTT;
import org.fusesource.mqtt.client.QoS;

import java.util.Random;

public class MQTTClient {
  public static void main(String[] args) throws Exception {
    MQTT mqtt = new MQTT();
    mqtt.setHost("127.0.0.1", 1883);
    mqtt.setUserName("root");
    mqtt.setPassword("root");
    mqtt.setConnectAttemptsMax(3);
    mqtt.setReconnectDelay(10);

    BlockingConnection connection = mqtt.blockingConnection();
    connection.connect();

    Random random = new Random();
    for (int i = 0; i < 100000; i++) {
      String payload =
          String.format(
              "{\n"
                  + "\"device\":\"root.sg.d1\",\n"
                  + "\"timestamp\":%d,\n"
                  + "\"measurements\":[\"s1\"],\n"
                  + "\"values\":[%f]\n"
                  + "}",
              System.currentTimeMillis(), random.nextDouble());

      // publish a json object
      Thread.sleep(1);
      connection.publish("root.sg.d1.s1", payload.getBytes(), QoS.AT_LEAST_ONCE, false);
    }
//    // publish a json array
//    sb.insert(0, "[");
//    sb.replace(sb.lastIndexOf(","), sb.length(), "]");
//    connection.publish("root.sg.d1.s1", sb.toString().getBytes(), QoS.AT_LEAST_ONCE, false);

    connection.disconnect();
  }
}

We can got the following result, for master branch we can see that the off heap will increase all the time, but this pr won't increase.
image

Copy link

sonarcloud bot commented Feb 19, 2024

@JackieTien97 JackieTien97 merged commit bcedeb7 into master Feb 19, 2024
34 of 37 checks passed
@JackieTien97 JackieTien97 deleted the IOTDB-6296 branch February 19, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants