Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOTDB-6299] Fix bug in merging overlapped data process caused by filter & offset push down #12068

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

liuminghui233
Copy link
Member

@liuminghui233 liuminghui233 commented Feb 22, 2024

[Reproduction Method]

  • Config:
    maxNumberOfPointsInPage = 2
    maxTsBlockLineNumber = 3

  • Insert:

    CREATE DATABASE root.sg1;
    create aligned timeseries root.sg1.d1(s1 FLOAT encoding=RLE, s2 INT32 encoding=Gorilla compression=SNAPPY, s3 INT64, s4 BOOLEAN, s5 TEXT);
    insert into root.sg1.d1(time, s1, s2, s3, s4, s5) aligned values(9, 9.0, 9, 9, FALSE, 'aligned_test9');
    insert into root.sg1.d1(time, s2, s3, s4, s5) aligned values(10, 10, 10, TRUE, 'aligned_test10');
    flush;
    insert into root.sg1.d1(time, s1, s2, s3) aligned values(11, 11.0, 11, 11);
    insert into root.sg1.d1(time, s1, s2, s3) aligned values(12, 12.0, 12, 12);
    insert into root.sg1.d1(time, s1, s2, s3) aligned values(13, 13.0, 13, 13);
    insert into root.sg1.d1(time, s1, s2, s3) aligned values(14, 14.0, 14, 14);
    insert into root.sg1.d1(time, s1, s2, s3) aligned values(15, 15.0, 15, 15);
    insert into root.sg1.d1(time, s1, s2, s3) aligned values(16, 16.0, 16, 16);
    insert into root.sg1.d1(time, s1, s2, s3) aligned values(17, 17.0, 17, 17);
    insert into root.sg1.d1(time, s1, s2, s3) aligned values(18, 18.0, 18, 18);
    insert into root.sg1.d1(time, s1, s2, s3) aligned values(19, 19.0, 19, 19);
    insert into root.sg1.d1(time, s1, s2, s3) aligned values(20, 20.0, 20, 20);
    flush;
    insert into root.sg1.d1(time, s1, s2, s3, s4, s5) aligned values(13, 130000.0, 130000, 130000, TRUE, 'aligned_unseq_test13');
    flush;
  • Query:

    select * from root.sg1.d1 where time >= 9 and time <= 33 offset 5 limit 5
    • Before:

    image

    • After:

    image

@liuminghui233 liuminghui233 changed the title Fix bug in Fix bug in merging overlapped data process caused by filter & offset push down Feb 22, 2024
@liuminghui233 liuminghui233 changed the title Fix bug in merging overlapped data process caused by filter & offset push down [IOTDB-6299] Fix bug in merging overlapped data process caused by filter & offset push down Feb 22, 2024
Copy link

sonarcloud bot commented Feb 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@JackieTien97 JackieTien97 merged commit b5dfbfd into master Feb 23, 2024
36 of 37 checks passed
@JackieTien97 JackieTien97 deleted the lmh/fixMergeReader branch February 23, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants