Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscription: thrift zero-copy optimization for SubscriptionSessionConnection #13322

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Subscription: thrift zero-copy optimization for SubscriptionSessionConnection #13322

wants to merge 3 commits into from

Conversation

VGalaxies
Copy link
Contributor

WIP...

@SteveYurongSu SteveYurongSu self-assigned this Aug 28, 2024
OneSizeFitsQuorum
OneSizeFitsQuorum reviewed Aug 28, 2024
View reviewed changes
Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on this!
Any Tesing result?

...ssion/src/main/java/org/apache/iotdb/session/subscription/SubscriptionSessionConnection.java
String trustStorePwd,
final BaseRpcTransportFactory rpcTransportFactory)
throws IoTDBConnectionException {
this.initTransportInternal(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use rpcTransportFactory?

@VGalaxies
Copy link
Contributor Author

Thanks a lot for working on this! Any Tesing result?

Still in WIP status (the current implementation cannot guarantee the security of deserialization 😶‍🌫️), performance test results will be provided after complete implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OneSizeFitsQuorum OneSizeFitsQuorum OneSizeFitsQuorum left review comments

Assignees

@SteveYurongSu SteveYurongSu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VGalaxies @OneSizeFitsQuorum @SteveYurongSu