Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add join operator implementation, fix the problem in join logical planner and distributed planner #13529

Merged
merged 54 commits into from
Sep 23, 2024

Conversation

Beyyes
Copy link
Member

@Beyyes Beyyes commented Sep 18, 2024

Description

As the title, see the key changed classes for more details.

  • iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/InnerJoinOperator.java
  • iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/optimizations/PushPredicateIntoTableScan.java

Integration test is shown in: integration-test/src/test/java/org/apache/iotdb/relational/it/db/it/IoTDBMultiIDsWithAttributesTableIT.java


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR
  • JoinOperator

@Beyyes Beyyes changed the title Add j operator implementation, fix the problem in join logical planner and distributed planner Add join operator implementation, fix the problem in join logical planner and distributed planner Sep 18, 2024
@Beyyes Beyyes marked this pull request as draft September 18, 2024 03:38
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 30.34826% with 280 lines in your changes missing coverage. Please review.

Project coverage is 41.69%. Comparing base (3f922e7) to head (68e6d8f).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
.../operator/source/relational/InnerJoinOperator.java 0.00% 189 Missing ⚠️
...yengine/plan/relational/planner/node/JoinNode.java 0.00% 58 Missing ⚠️
...eryengine/plan/planner/TableOperatorGenerator.java 0.00% 24 Missing ⚠️
...execution/relational/ColumnTransformerBuilder.java 0.00% 2 Missing ⚠️
...otdb/db/queryengine/plan/analyze/TypeProvider.java 0.00% 2 Missing ⚠️
...ngine/plan/planner/plan/node/PlanGraphPrinter.java 0.00% 2 Missing ⚠️
...ne/execution/fragment/FragmentInstanceContext.java 0.00% 1 Missing ⚠️
...eryengine/plan/planner/plan/node/PlanNodeType.java 50.00% 1 Missing ⚠️
...e/plan/planner/plan/node/process/ExchangeNode.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13529      +/-   ##
============================================
- Coverage     41.77%   41.69%   -0.09%     
  Complexity       71       71              
============================================
  Files          3978     3983       +5     
  Lines        247469   247847     +378     
  Branches      29962    30033      +71     
============================================
- Hits         103377   103331      -46     
- Misses       144092   144516     +424     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Beyyes Beyyes marked this pull request as ready for review September 20, 2024 06:59
Copy link

sonarcloud bot commented Sep 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@JackieTien97 JackieTien97 merged commit 6b17e71 into master Sep 23, 2024
27 of 29 checks passed
@JackieTien97 JackieTien97 deleted the beyyes/joinOperator branch September 23, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants