-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove datanode optimization #13559
Remove datanode optimization #13559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL~
...onfignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RemoveDataNodeManager.java
Outdated
Show resolved
Hide resolved
.../test/java/org/apache/iotdb/confignode/procedure/impl/node/RemoveDataNodesProcedureTest.java
Outdated
Show resolved
Hide resolved
...onfignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RemoveDataNodeManager.java
Outdated
Show resolved
Hide resolved
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java
Outdated
Show resolved
Hide resolved
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java
Show resolved
Hide resolved
...onfignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RemoveDataNodeManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
I have left� some issues, PTAL
...src/test/java/org/apache/iotdb/confignode/it/removedatanode/IoTDBRemoveDataNodeNormalIT.java
Outdated
Show resolved
Hide resolved
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java
Show resolved
Hide resolved
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/node/NodeManager.java
Outdated
Show resolved
Hide resolved
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/assembly/resources/sbin/remove-datanode.sh
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/iotdb/confignode/procedure/impl/node/RemoveDataNodesProcedure.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/iotdb/confignode/procedure/impl/node/RemoveDataNodesProcedure.java
Outdated
Show resolved
Hide resolved
...onfignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RemoveDataNodeManager.java
Outdated
Show resolved
Hide resolved
...onfignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RemoveDataNodeManager.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/iotdb/confignode/procedure/impl/node/RemoveDataNodesProcedure.java
Show resolved
Hide resolved
...src/test/java/org/apache/iotdb/confignode/it/removedatanode/IoTDBRemoveDataNodeNormalIT.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/apache/iotdb/confignode/it/removedatanode/IoTDBRemoveDataNodeNormalIT.java
Outdated
Show resolved
Hide resolved
...onfignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RemoveDataNodeHandler.java
Outdated
Show resolved
Hide resolved
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/service/ConfigNode.java
Outdated
Show resolved
Hide resolved
...onfignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RemoveDataNodeHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
ConfigNode
remove-datanode script
IT tests