Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe: Avoid type conversion if error on receiver is caused by insufficient memory #13569

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

SteveYurongSu
Copy link
Member

As title.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.72%. Comparing base (3ca3f44) to head (3a84621).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
.../PipeStatementDataTypeConvertExecutionVisitor.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13569      +/-   ##
============================================
- Coverage     41.84%   41.72%   -0.13%     
  Complexity       71       71              
============================================
  Files          3978     3980       +2     
  Lines        247518   248067     +549     
  Branches      29975    30089     +114     
============================================
- Hits         103581   103513      -68     
- Misses       143937   144554     +617     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SteveYurongSu SteveYurongSu reopened this Sep 22, 2024
@SteveYurongSu SteveYurongSu merged commit f87de7f into master Sep 22, 2024
40 of 43 checks passed
@SteveYurongSu SteveYurongSu deleted the do-not-convert-when-receiver-load-oom branch September 22, 2024 15:34
Copy link

sonarcloud bot commented Sep 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
9.2% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

VGalaxies pushed a commit to VGalaxies/iotdb that referenced this pull request Oct 11, 2024
SteveYurongSu added a commit that referenced this pull request Oct 12, 2024
…cient memory (#13569) (#13723)

Co-authored-by: Steve Yurong Su <rong@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant