Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AINode: Correcting the Omissions and Redundancies #13594

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Conversation

ycycse
Copy link
Member

@ycycse ycycse commented Sep 23, 2024

  1. Add logic of plan deserialization in configNode
  2. Remove AINodeService in datanode which is not used anymore.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.

Project coverage is 41.42%. Comparing base (040dcf1) to head (035770f).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...nfignode/consensus/request/ConfigPhysicalPlan.java 0.00% 20 Missing ⚠️
...de/consensus/request/read/model/ShowModelPlan.java 0.00% 10 Missing ⚠️
...equest/read/ainode/GetAINodeConfigurationPlan.java 0.00% 7 Missing ⚠️
...consensus/request/read/model/GetModelInfoPlan.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13594      +/-   ##
============================================
+ Coverage     41.40%   41.42%   +0.01%     
  Complexity       71       71              
============================================
  Files          3997     3994       -3     
  Lines        248205   248165      -40     
  Branches      30101    30103       +2     
============================================
+ Hits         102775   102790      +15     
+ Misses       145430   145375      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SteveYurongSu SteveYurongSu self-assigned this Sep 24, 2024
# Conflicts:
#	iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java
Copy link

sonarcloud bot commented Sep 25, 2024

@SteveYurongSu SteveYurongSu merged commit ee9b752 into master Sep 25, 2024
28 checks passed
@SteveYurongSu SteveYurongSu deleted the FillAINode branch September 25, 2024 07:56
ycycse added a commit that referenced this pull request Sep 26, 2024
* Add logic of plan deserialization in configNode

* remove AINodeService in datanode which is not used anymore.

(cherry picked from commit ee9b752)
ycycse added a commit that referenced this pull request Sep 26, 2024
* Add logic of plan deserialization in configNode

* remove AINodeService in datanode which is not used anymore.

(cherry picked from commit ee9b752)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants