Pipe: export tsfile sink #14111
Open
Pipe: export tsfile sink #14111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+78
to
+80
| if (!exportPath.exists() && !exportPath.mkdirs()) { | ||
| throw new PipeException("Export TsFile path not exist and can't be created"); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (!exportPath.exists() && !exportPath.mkdirs()) { | |
| throw new PipeException("Export TsFile path not exist and can't be created"); | |
| } | |
| synchornized (ExportTsFileConnector.class) { | |
| if (!exportPath.exists() && !exportPath.mkdirs()) { | |
| throw new PipeException("Export TsFile path not exist and can't be created"); | |
| } | |
| } |
|
|
||
| @Override | ||
| public void heartbeat() throws Exception { | ||
| handshake(); |
|
|
||
| final PipeTsFileInsertionEvent event = (PipeTsFileInsertionEvent) tsFileInsertionEvent; | ||
| final File sourceTsFile = event.getTsFile(); | ||
| final File targetPath = new File(exportPath, sourceTsFile.getName()); |
There was a problem hiding this comment.
Different regions, the same name?
There was a problem hiding this comment.
客户目录检查下载文件的时候，会不会往子目录去检测？需要确认
There was a problem hiding this comment.
It seems that sourceTsFile.getName() returns the name of pipe-pinned tsfiles, which include region id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.