Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor UDF management process to support table model user-defined function #14135

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

Cpaulyz
Copy link
Contributor

@Cpaulyz Cpaulyz commented Nov 19, 2024

Description

  1. Refactor UDF management process. Most important change is to introduce an enum type Model. UDFTable use Pair<Model, String> as hash key to support table model user-defined function now.
  2. Introduce pre create and pre drop process to avoid some corner cases due to partial create/drop. Function with UNAVAILABLE state in SHOW FUNCTIONS will perform some unexpected behaviors.

See https://timechor.feishu.cn/docx/TCyYdm8pYowe0HxEGb9c2UfenCf for more details.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 24.19355% with 282 lines in your changes missing coverage. Please review.

Project coverage is 39.65%. Comparing base (b8432f8) to head (656dc4c).
Report is 75 commits behind head on master.

Files with missing lines Patch % Lines
...n/execution/config/metadata/ShowFunctionsTask.java 0.00% 50 Missing ⚠️
...rg/apache/iotdb/confignode/manager/UDFManager.java 0.00% 42 Missing ⚠️
...otdb/commons/udf/service/UDFManagementService.java 33.33% 42 Missing ⚠️
...otdb/commons/udf/service/UDFExecutableManager.java 0.00% 25 Missing ⚠️
...ion/config/executor/ClusterConfigTaskExecutor.java 0.00% 19 Missing ⚠️
...sus/request/write/function/UpdateFunctionPlan.java 0.00% 17 Missing ⚠️
...g/apache/iotdb/confignode/persistence/UDFInfo.java 0.00% 15 Missing ⚠️
.../execution/config/metadata/CreateFunctionTask.java 0.00% 13 Missing ⚠️
...in/java/org/apache/iotdb/commons/udf/UDFTable.java 66.66% 9 Missing ⚠️
...a/org/apache/iotdb/commons/udf/UDFInformation.java 61.90% 8 Missing ⚠️
... and 16 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14135      +/-   ##
============================================
- Coverage     39.95%   39.65%   -0.31%     
  Complexity       71       71              
============================================
  Files          4191     4228      +37     
  Lines        265828   269326    +3498     
  Branches      32265    32642     +377     
============================================
+ Hits         106217   106795     +578     
- Misses       159611   162531    +2920     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

sonarcloud bot commented Nov 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
8.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant