Unaligned tvlist feat #14265
Open
Unaligned tvlist feat #14265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shizy818
force-pushed
the
unaligned-tvlist-feat
branch
from
a9c5aab to
215cb4b
Compare
shizy818
commented
Dec 2, 2024
...de/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/ReadOnlyMemChunk.java
Show resolved
Hide resolved
shizy818
commented
Dec 2, 2024
.../main/java/org/apache/iotdb/db/storageengine/dataregion/read/reader/chunk/MemPageReader.java
Outdated
Show resolved
Hide resolved
shizy818
commented
Dec 2, 2024
...rc/main/java/org/apache/iotdb/db/queryengine/execution/fragment/FragmentInstanceContext.java
Show resolved
Hide resolved
HTHou
reviewed
Dec 3, 2024
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/datastructure/TimLongTVList.java
Show resolved
Hide resolved
jt2594838
approved these changes
Dec 3, 2024
...de/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/ReadOnlyMemChunk.java
Outdated
Show resolved
Hide resolved
...de/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/ReadOnlyMemChunk.java
Outdated
Show resolved
Hide resolved
...de/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/WritableMemChunk.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/iotdb/db/storageengine/dataregion/read/reader/chunk/MemChunkReader.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/iotdb/db/storageengine/dataregion/read/reader/chunk/MemPageReader.java
Outdated
Show resolved
Hide resolved
| Binary valueP = getBinary(p); | ||
| int valueP = getValueIndex(p); | ||
| long timeP = getTime(p); | ||
| Binary valueQ = getBinary(q); | ||
| int valueQ = getValueIndex(q); |
There was a problem hiding this comment.
Better to rename the variables. The same below.
There was a problem hiding this comment.
Maybe I can to do this change later, and move common methods to XXXSort.
[HTHou](https://github.com/HTHou) [Dec 3, 2024](https://github.com/apache/iotdb/pull/14265#discussion_r1866983823)
这个方法看起来各个实现类里都变成一样的了，是不是可以放到 TimSort.java 里
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/datastructure/TVList.java
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/datastructure/TVList.java
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/datastructure/TVList.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/iotdb/db/storageengine/dataregion/read/reader/chunk/MemChunkLoaderTest.java
Outdated
Show resolved
Hide resolved
jt2594838
approved these changes
Dec 4, 2024
shizy818
force-pushed
the
unaligned-tvlist-feat
branch
from
ae4d92b to
a033bc9
Compare
shizy818
force-pushed
the
unaligned-tvlist-feat
branch
from
0edb9c6 to
5aaa59b
Compare
jt2594838
approved these changes
Dec 5, 2024
shizy818
force-pushed
the
unaligned-tvlist-feat
branch
from
9d1de83 to
cd3f7d9
Compare
shizy818
force-pushed
the
unaligned-tvlist-feat
branch
from
d65c4f7 to
73e9f83
Compare
shizy818
force-pushed
the
unaligned-tvlist-feat
branch
from
1a53a0b to
9411fea
Compare
* change some list to array * remember row count in tvlist iterator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Content1 ...
Content2 ...
Content3 ...
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR