Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in string/timestamp/date/blob data type + sort + limit usage in version 1.3.x #14323

Merged
merged 6 commits into from
Dec 5, 2024

Conversation

Beyyes
Copy link
Member

@Beyyes Beyyes commented Dec 5, 2024

Description

As the title. See details in #14173


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Copy link

sonarqubecloud bot commented Dec 5, 2024

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.25%. Comparing base (26faf24) to head (aee5008).
Report is 2 commits behind head on dev/1.3.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev/1.3   #14323      +/-   ##
=============================================
- Coverage      41.25%   41.25%   -0.01%     
  Complexity        71       71              
=============================================
  Files           3471     3471              
  Lines         222443   222443              
  Branches       26435    26435              
=============================================
- Hits           91772    91764       -8     
- Misses        130671   130679       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Beyyes Beyyes changed the title Fix error in new data type + sort + limit usage in version 1.3.x Fix error in string/timestamp/date/blob data type + sort + limit usage in version 1.3.x Dec 5, 2024
@Beyyes Beyyes merged commit 87c597d into dev/1.3 Dec 5, 2024
27 checks passed
@Beyyes Beyyes deleted the fix_topk_1.3 branch December 5, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

查询时 order by 与 limit 同时使用的情况可能提示 Unknown datatype: STRING
2 participants