[IOTDB-1463] Implement builder pattern for Session and SessionPool #3502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangchao316
requested changes
Jul 5, 2021
Contributor
There was a problem hiding this comment.
Great Job！
Only minor issues!
- As we can directly use
sh sbin/start-cli.shto connect server with default host "127.0.0.1" and default port "6667" using default user "root" with default password "root", So I think the host and port of session/sessionPool can also have default values. On the one hand, it is more convenient to test IoTDB locally, on the other hand, it makes the session/sessionPool interface consistent with CLI. BTW, it's my fault to make a wrong example. Actually, A built-in-class builder creation must be performed just like "Session.Builder.build()" rather than 'SessionBuilder.build()' - Please update the docs in
Programming-Native-API.md. - After this PR has been merged, please send an email to the community telling everyone how the new session/sessionPool can be created now.
Contributor
Author
|
Thanks for the comments! Have changed accordingly. I removed the old construction method in the docs and also changed examples, so that new users can use builder as a preferred way. Will blast out an email after this is merged~ |
Contributor
OneSizeFitsQuorum
left a comment
OneSizeFitsQuorum
left a comment
There was a problem hiding this comment.
Last minor issue!
session/src/main/java/org/apache/iotdb/session/pool/SessionPool.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing a more fluent way to construct Session and SessionPool