[To rel/0.12] Use StringCachedPool in TsFileResource to reduce the memory size #3514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangchao316
reviewed
Jul 6, 2021
| } | ||
|
|
||
| public void updateStartTime(String device, long time) { | ||
| device = device.intern(); |
Member
There was a problem hiding this comment.
LGTM.
hi , haonan , I have a minor question.
Because using the internal method has a performance impact. If intern() is performed after a new string is generated, the query performance will be affected，This needs to be considered. If the memory consumption and gc time are longer than intern, I agree with using intern().
Contributor
Author
There was a problem hiding this comment.
Hi, this pr is under testing and won't be merged until we get the performance result.
Contributor
Author
There was a problem hiding this comment.
By the way, it is a temporary way to reduce the memory size of TsFileResource. Actually, we are considering to remove the Devices set in FileTimeIndex.
HTHou
changed the title
|
SonarCloud Quality Gate failed. |
HTHou
changed the title
qiaojialin
approved these changes
Jul 7, 2021
SteveYurongSu
approved these changes
Jul 7, 2021
HTHou
added a commit
that referenced
this pull request
Jul 7, 2021
SteveYurongSu
pushed a commit
that referenced
this pull request
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.