OAK-10758: Proposal: Add system property to control noCursorTimeout in Mongo iterator #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joscorbe
changed the title
stefan-egli
reviewed
Apr 15, 2024
There was a problem hiding this comment.
What about only calling noCursorTimeout() if it is set to true ? (would leave things unchanged if this property is not set or set to false)
PS: as per docu there could still be a MongoCursorNotFoundException thrown if the session times out (eg after 30min). I.e. if the problem persists even with noCursorTimeout=true we might have to shrink the batch size (or introduce explicit refreshSessions calls)
or put differently : a smaller batch size could also be something to look into in general
...ument/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java
Outdated
Show resolved
Hide resolved
Co-authored-by: stefan-egli <stefanegli@apache.org>
stefan-egli
approved these changes
Apr 15, 2024
rishabhdaim
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a proposal to solve https://issues.apache.org/jira/browse/OAK-10758
Another proposal PR is coming, that improves exception handling to avoid crashing when this exception is thrown.