-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAK-11267 - Upgrade Azure SDK V8 to V12 for oak-blob-azure #1861
base: trunk
Are you sure you want to change the base?
Conversation
Every larger PR needs a JIRA ticket in https://issues.apache.org/jira/projects/OAK! |
import org.jetbrains.annotations.NotNull; | ||
import org.jetbrains.annotations.Nullable; | ||
|
||
public final class UtilsV12 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the classes with version v8 should have in the name V8 and the classes with the new version (v 12) should have the name with no version
Hi! I linked this PR with this JIRA issue: https://issues.apache.org/jira/browse/OAK-11267 . Please let me know if something else is required. |
Please read https://jackrabbit.apache.org/oak/docs/participating.html. Currently the commit message does not reference the Oak issue. |
f46fa09
to
e33c861
Compare
@kwin , maybe it's just style.... but to me your review comments don't come across as welcoming (see https://apache.org/foundation/policies/conduct). @andreeastroe96 is a new contributor to the project and there is IMHO no need to be angry... a friendly reminder will do magic. |
@anchela You are right. |
e33c861
to
2949118
Compare
No description provided.