Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAK-11269 add dedicated workflow for checking commit messages #1865

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

kwin
Copy link
Member

@kwin kwin commented Nov 14, 2024

OAK-11269 my test

@kwin kwin force-pushed the feature/commit-check branch 3 times, most recently from da9cd31 to 554532a Compare November 18, 2024 16:12
Copy link

github-actions bot commented Nov 18, 2024

Commit-Check ✔️

@kwin kwin changed the title incorrect message OAK-11269 add dedicated workflow for checking commit messages Nov 18, 2024
@kwin kwin requested a review from reschke November 18, 2024 16:17
@kwin kwin marked this pull request as ready for review November 18, 2024 16:17
@Joscorbe
Copy link
Member

This is a good idea, but got a question, will this check enforce the OAK- also in commits created by bots? I think that will fail in PRs like #1860

@kwin
Copy link
Member Author

kwin commented Nov 18, 2024

For now it is just a check which fails (on every PR which is not compliant). However there is nothing enforced right now, i.e. a failed check will not prevent merging via UI.

@Joscorbe
Copy link
Member

For now it is just a check which fails (on every PR which is not compliant). However there is nothing enforced right now, i.e. a failed check will not prevent merging via UI.

Sounds good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants