Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAK-11105: Remove usage of Guava ImmutableMap.of() - zero/one argument case #1869

Open
wants to merge 26 commits into
base: trunk
Choose a base branch
from
Open

OAK-11105: Remove usage of Guava ImmutableMap.of() - zero/one argument case #1869

wants to merge 26 commits into from

Conversation

reschke
Copy link
Contributor

@reschke reschke commented Nov 18, 2024

No description provided.

@reschke reschke marked this pull request as draft November 18, 2024 21:27
mbaedke
mbaedke reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@mbaedke mbaedke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't some of the imports already be removed, e.g. in AbstractAccessControlManagerTest?

@reschke
OAK-11105: remove ImmutableMap.of(a, b) - oak-benchmarks-elastic
d310002
@reschke
OAK-11105: remove ImmutableMap.of(a, b) - oak-benchmarks-lucene
4e431c2
@reschke
OAK-11105: remove ImmutableMap.of(a, b) - oak-benchmarks-solr
1e18c6f
@reschke
OAK-11105: remove ImmutableMap.of(a, b) - oak-blob-plugins
66de419
@reschke
OAK-11105: remove ImmutableMap.of(a, b) - oak-auth-ldap
1a52630
@reschke
OAK-11105: remove ImmutableMap.of(a, b) - oak-run-elastic
c928ea4
@reschke
OAK-11105: remove ImmutableMap.of(a, b) - oak-it
9e73131
@reschke
OAK-11105: remove ImmutableMap.of(a, b) - oak-upgrade
302441b
@reschke
OAK-11105: remove ImmutableMap.of(a, b) - oak-doc
4d04c7e
@reschke
OAK-11105: remove ImmutableMap.of(a, b) - oak-store-spi
d745b9b
@reschke
OAK-11105: remove ImmutableMap.of(a, b) - oak-benchmarks
8a69f30
@reschke
OAK-11105: remove ImmutableMap.of(a, b) - oak-store-document
fd06f84
@reschke
OAK-11105: remove ImmutableMap.of(a, b) - oak-lucene
61c08d6
@reschke
OAK-11105: remove ImmutableMap.of(a, b) - oak-store-composite
aa99f35
@reschke
OAK-11105: remove ImmutableMap.of(a, b) - oak-core-spi
22d9326
@reschke
OAK-11105: remove ImmutableMap.of(a, b) - oak-jcr
ffe5fee
@reschke
OAK-11105: remove ImmutableMap.of(a, b) - oak-segment-tar
a8791d1
@reschke
OAK-11105: remove ImmutableMap.of(a, b) - oak-authorization-cug
d1d2b7a
@mbaedke mbaedke self-requested a review November 19, 2024 14:15
@reschke reschke changed the title OAK-11105: Remove usage of Guava ImmutableMap.of() - zero argument case OAK-11105: Remove usage of Guava ImmutableMap.of() - zero/one argument case Nov 21, 2024
@reschke
Copy link
Contributor Author

reschke commented Nov 21, 2024

Re: unneeded imports; there are a few related to the removal ImmutableSet. I'll fix those separately.

@reschke reschke marked this pull request as ready for review November 21, 2024 18:32
@reschke reschke requested a review from mbaedke November 21, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anchela anchela Awaiting requested review from anchela

@rishabhdaim rishabhdaim Awaiting requested review from rishabhdaim

@mbaedke mbaedke Awaiting requested review from mbaedke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reschke @mbaedke