[GH-1889] Use arguments for uid and gid, add group and user, re-work order of commands to make dirs and change ownership #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I adapted this code from the Micromamba docker recipe 👍 |
rvesse
approved these changes
May 31, 2023
afs
approved these changes
Jun 1, 2023
kinow
commented
Jun 1, 2023
| ARG JENA_UID=1000 | ||
|
|
||
| # Run as this user | ||
| # -H : no home directorry |
There was a problem hiding this comment.
Will push force just to rebase & fix this (copied) typo (s/directorry/directory), then merge 👍
…-work order of commands to make dirs and change ownership
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved #1889
Pull request Description:
Moves
adduserto final layer only (we were creating and then copying/etc/passwd). Runsaddgroupbefore, and uses a fixed uid/gid for user and group.Create base directory, changes ownership, and then switches to the Jena user in Docker. That creates everything else with the correct uid/gid/ownership.
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.