Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2153: Compile Element when not it is in an ElementGroup #2155

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

afs
Copy link
Member

@afs afs commented Jan 5, 2024

Part of #2153

Handle the non-parser case of a ElementFilter in the query AST which is not within a ElementGroup.


  • Tests are included.
  • Commits have been squashed to remove intermediate development commit messages.
  • Key commit messages start with the issue number (GH-xxxx, or if in JIRA, JENA-xxxx)

By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.

@afs
Copy link
Member Author

afs commented Jan 5, 2024

This PR also converts the uses of instanceof to use pattern variables.

@afs afs force-pushed the gh2153-compile-filter branch 2 times, most recently from b6d373a to b6394c0 Compare January 5, 2024 11:32
@afs
Copy link
Member Author

afs commented Jan 5, 2024

Related to #2152.

@afs afs changed the title GH-2153: Compile ElementFilter when not in an ElementGroup GH-2153: Compile Element when not they are not in an ElementGroup Jan 5, 2024
@afs afs marked this pull request as ready for review January 5, 2024 22:15
@afs afs force-pushed the gh2153-compile-filter branch 2 times, most recently from 46db7ec to aad0c09 Compare January 6, 2024 13:33
@afs afs changed the title GH-2153: Compile Element when not they are not in an ElementGroup GH-2153: Compile Element when not it is in an ElementGroup Jan 8, 2024
Copy link
Member

@rvesse rvesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afs afs merged commit b9c8739 into apache:main Jan 11, 2024
@afs afs deleted the gh2153-compile-filter branch January 11, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants