Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2833: Handle x flag in java regex #2876

Merged
merged 1 commit into from
Dec 4, 2024
Merged

GH-2833: Handle x flag in java regex #2876

merged 1 commit into from
Dec 4, 2024

Conversation

afs
Copy link
Member

@afs afs commented Dec 2, 2024

Improve the regex coverage after refactoring of #2833

  • Support x flag using Java Pattern.COMMENTS
  • Refactor switch statement
  • Include all meta characters in REUtil (A Xerces fix!)

This arose for additional tests for regex in rdf-tests.


  • Tests will be included when the rdf-tests changes are merged then copied into Jena.
  • Key commit messages start with the issue number (GH-xxxx)

By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.

@afs afs self-assigned this Dec 2, 2024
@afs afs changed the title GH-2833: Handled x flag in java regex GH-2833: Handle x flag in java regex Dec 2, 2024
@afs afs merged commit 04c40e4 into apache:main Dec 4, 2024
4 checks passed
@afs afs deleted the regex branch December 4, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants