Use Class#asSubclass in JavaConfigGui to check class before its const…

…ructor is called
apache · Oct 18, 2020 · 3a512c6 · 3a512c6
1 parent 6587c45
commit 3a512c6
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/...protocol/java/src/main/java/org/apache/jmeter/protocol/java/config/gui/JavaConfigGui.java b/...protocol/java/src/main/java/org/apache/jmeter/protocol/java/config/gui/JavaConfigGui.java
@@ -187,8 +187,10 @@ public void stateChanged(ChangeEvent evt) {
     private void configureClassName() {
         String className = classNameLabeledChoice.getText().trim();
         try {
-            JavaSamplerClient client = (JavaSamplerClient) Class.forName(className, true,
-                    Thread.currentThread().getContextClassLoader()).getDeclaredConstructor().newInstance();
+            JavaSamplerClient client = Class.forName(className, true,
+                    Thread.currentThread().getContextClassLoader())
+                    .asSubclass(JavaSamplerClient.class)
+                    .getDeclaredConstructor().newInstance();
 
             Arguments currArgs = new Arguments();
             argsPanel.modifyTestElement(currArgs);
@@ -267,8 +269,10 @@ public void configure(TestElement config) {
      */
     private boolean classOk(String className) {
         try {
-            JavaSamplerClient client = (JavaSamplerClient) Class.forName(className, true,
-                    Thread.currentThread().getContextClassLoader()).getDeclaredConstructor().newInstance();
+            JavaSamplerClient client = Class.forName(className, true,
+                    Thread.currentThread().getContextClassLoader())
+                    .asSubclass(JavaSamplerClient.class)
+                    .getDeclaredConstructor().newInstance();
             // Just to use client
             return client != null;
         } catch (Exception ex) {