Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the wrong throughput of the ConstantThroughputTimer #6280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

onionzz
Copy link

@onionzz onionzz commented May 20, 2024

Description

Fix #6278

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.

@vlsi
Copy link
Collaborator

vlsi commented May 20, 2024

Did you consider adding tests for the change?

@FSchumacher
Copy link
Contributor

I think the current implementation of ConstantThroughputTimer does not allow for really high throughput timing, as it relies on the timer resolution for sleep, which is milliseconds.

If we want to go for higher resolution, we would have to add more state, to allow now sleeping, when we expect to have more than one sampler in one millisecond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constant Throughput timer with shared algorithm generate wrong throughput when target throughput is big
3 participants