Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add checkbox to enable/disable params in HTTP Sampler #6291

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: Add checkbox to enable/disable params in HTTP Sampler #6291

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
06085e2
feat: Add checkbox to enable/disable params in HTTP Sampler
pochopsp Jun 11, 2024
45c45e7
Add missing enabled_from_gui to HTTPArgument in test files
pochopsp Jun 16, 2024
75f5376
Merge branch 'master' into #5466-HTTP-disable-params
pochopsp Nov 1, 2024
ad16381
Use TestElementSchema.enabled instead of new HTTPArgumentSchema.enabl…
pochopsp Nov 8, 2024
33e0cf4
Revert "Add missing enabled_from_gui to HTTPArgument in test files"
pochopsp Nov 8, 2024
4ea8f7e
Remove unnecessary boolProp TestElement.enabled from TEST_HTTP.jmx
pochopsp Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bin/testfiles/GuiTest231.jmx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@
<collectionProp name="Arguments.arguments">
<elementProp name="" elementType="HTTPArgument">
<boolProp name="HTTPArgument.always_encode">false</boolProp>
<boolProp name="HTTPArgument.enabled_from_gui">true</boolProp>
<stringProp name="Argument.value">Value</stringProp>
<stringProp name="Argument.metadata">=</stringProp>
<boolProp name="HTTPArgument.use_equals">true</boolProp>
Expand Down Expand Up @@ -395,6 +396,7 @@
<collectionProp name="Arguments.arguments">
<elementProp name="" elementType="HTTPArgument">
<boolProp name="HTTPArgument.always_encode">false</boolProp>
<boolProp name="HTTPArgument.enabled_from_gui">true</boolProp>
<stringProp name="Argument.value">Value</stringProp>
<stringProp name="Argument.metadata">=</stringProp>
<boolProp name="HTTPArgument.use_equals">true</boolProp>
Expand Down
2 changes: 2 additions & 0 deletions bin/testfiles/GuiTest231_original.jmx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@
<collectionProp name="Arguments.arguments">
<elementProp name="" elementType="HTTPArgument">
<boolProp name="HTTPArgument.always_encode">false</boolProp>
<boolProp name="HTTPArgument.enabled_from_gui">true</boolProp>
<stringProp name="Argument.value">Value</stringProp>
<stringProp name="Argument.metadata">=</stringProp>
<boolProp name="HTTPArgument.use_equals">true</boolProp>
Expand Down Expand Up @@ -410,6 +411,7 @@
<collectionProp name="Arguments.arguments">
<elementProp name="" elementType="HTTPArgument">
<boolProp name="HTTPArgument.always_encode">false</boolProp>
<boolProp name="HTTPArgument.enabled_from_gui">true</boolProp>
<stringProp name="Argument.value">Value</stringProp>
<stringProp name="Argument.metadata">=</stringProp>
<boolProp name="HTTPArgument.use_equals">true</boolProp>
Expand Down
2 changes: 2 additions & 0 deletions bin/testfiles/Modification Manager.jmx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
<boolProp name="HTTPArgument.use_equals">true</boolProp>
<stringProp name="Argument.name">request.job_id</stringProp>
<stringProp name="HTTPArgument.always_encode">true</stringProp>
<boolProp name="HTTPArgument.enabled_from_gui">true</boolProp>
<stringProp name="HTTPArgument.encoded_name">request.job_id</stringProp>
<stringProp name="HTTPArgument.encoded_value">.*</stringProp>
</elementProp>
Expand All @@ -33,6 +34,7 @@
<boolProp name="HTTPArgument.use_equals">true</boolProp>
<stringProp name="Argument.name">request.action1</stringProp>
<stringProp name="HTTPArgument.always_encode">true</stringProp>
<boolProp name="HTTPArgument.enabled_from_gui">true</boolProp>
<stringProp name="HTTPArgument.encoded_name">request.action1</stringProp>
<stringProp name="HTTPArgument.encoded_value">opjobadmin.action.inspect</stringProp>
</elementProp>
Expand Down
2 changes: 2 additions & 0 deletions bin/testfiles/SavedGuiTest231.jmx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@
<collectionProp name="Arguments.arguments">
<elementProp name="" elementType="HTTPArgument">
<boolProp name="HTTPArgument.always_encode">false</boolProp>
<boolProp name="HTTPArgument.enabled_from_gui">true</boolProp>
<stringProp name="Argument.value">Value</stringProp>
<stringProp name="Argument.metadata">=</stringProp>
<boolProp name="HTTPArgument.use_equals">true</boolProp>
Expand Down Expand Up @@ -395,6 +396,7 @@
<collectionProp name="Arguments.arguments">
<elementProp name="" elementType="HTTPArgument">
<boolProp name="HTTPArgument.always_encode">false</boolProp>
<boolProp name="HTTPArgument.enabled_from_gui">true</boolProp>
<stringProp name="Argument.value">Value</stringProp>
<stringProp name="Argument.metadata">=</stringProp>
<boolProp name="HTTPArgument.use_equals">true</boolProp>
Expand Down
12 changes: 12 additions & 0 deletions bin/testfiles/TEST_HTTP.jmx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ mirrorServer.start();</stringProp>
<collectionProp name="Arguments.arguments">
<elementProp name="name1" elementType="HTTPArgument">
<boolProp name="HTTPArgument.always_encode">false</boolProp>
<boolProp name="HTTPArgument.enabled_from_gui">true</boolProp>
<stringProp name="Argument.value">value1</stringProp>
<stringProp name="Argument.metadata">=</stringProp>
<boolProp name="HTTPArgument.use_equals">true</boolProp>
Expand Down Expand Up @@ -219,6 +220,7 @@ mirrorServer.start();</stringProp>
<collectionProp name="Arguments.arguments">
<elementProp name="" elementType="HTTPArgument">
<boolProp name="HTTPArgument.always_encode">false</boolProp>
<boolProp name="HTTPArgument.enabled_from_gui">true</boolProp>
<stringProp name="Argument.value">Get with body</stringProp>
<stringProp name="Argument.metadata">=</stringProp>
</elementProp>
Expand Down Expand Up @@ -532,6 +534,7 @@ mirrorServer.start();</stringProp>
<collectionProp name="Arguments.arguments">
<elementProp name="" elementType="HTTPArgument">
<boolProp name="HTTPArgument.always_encode">false</boolProp>
<boolProp name="HTTPArgument.enabled_from_gui">true</boolProp>
<stringProp name="Argument.value">Method has body</stringProp>
<stringProp name="Argument.metadata">=</stringProp>
</elementProp>
Expand Down Expand Up @@ -599,6 +602,7 @@ mirrorServer.start();</stringProp>
<collectionProp name="Arguments.arguments">
<elementProp name="" elementType="HTTPArgument">
<boolProp name="HTTPArgument.always_encode">false</boolProp>
<boolProp name="HTTPArgument.enabled_from_gui">true</boolProp>
<stringProp name="Argument.value">We have a body</stringProp>
<stringProp name="Argument.metadata">=</stringProp>
</elementProp>
Expand Down Expand Up @@ -740,6 +744,7 @@ mirrorServer.start();</stringProp>
<collectionProp name="Arguments.arguments">
<elementProp name="name1" elementType="HTTPArgument">
<boolProp name="HTTPArgument.always_encode">false</boolProp>
<boolProp name="HTTPArgument.enabled_from_gui">true</boolProp>
<stringProp name="Argument.value">value1</stringProp>
<stringProp name="Argument.metadata">=</stringProp>
<boolProp name="HTTPArgument.use_equals">true</boolProp>
Expand Down Expand Up @@ -792,6 +797,7 @@ mirrorServer.start();</stringProp>
<collectionProp name="Arguments.arguments">
<elementProp name="name1" elementType="HTTPArgument">
<boolProp name="HTTPArgument.always_encode">false</boolProp>
<boolProp name="HTTPArgument.enabled_from_gui">true</boolProp>
<stringProp name="Argument.value">value1</stringProp>
<stringProp name="Argument.metadata">=</stringProp>
<boolProp name="HTTPArgument.use_equals">true</boolProp>
Expand Down Expand Up @@ -859,13 +865,15 @@ mirrorServer.start();</stringProp>
<collectionProp name="Arguments.arguments">
<elementProp name="name1" elementType="HTTPArgument">
<boolProp name="HTTPArgument.always_encode">false</boolProp>
<boolProp name="HTTPArgument.enabled_from_gui">true</boolProp>
<stringProp name="Argument.value">value1</stringProp>
<stringProp name="Argument.metadata">=</stringProp>
<boolProp name="HTTPArgument.use_equals">true</boolProp>
<stringProp name="Argument.name">name1</stringProp>
</elementProp>
<elementProp name="安_param" elementType="HTTPArgument">
<boolProp name="HTTPArgument.always_encode">false</boolProp>
<boolProp name="HTTPArgument.enabled_from_gui">true</boolProp>
<stringProp name="Argument.value">value2</stringProp>
<stringProp name="Argument.metadata">=</stringProp>
<boolProp name="HTTPArgument.use_equals">true</boolProp>
Expand Down Expand Up @@ -948,6 +956,7 @@ if(prev.getSamplerData().indexOf(textToCheck) &lt; 0) {
<collectionProp name="Arguments.arguments">
<elementProp name="" elementType="HTTPArgument">
<boolProp name="HTTPArgument.always_encode">false</boolProp>
<boolProp name="HTTPArgument.enabled_from_gui">true</boolProp>
<stringProp name="Argument.value">Veni vidi vici</stringProp>
<stringProp name="Argument.metadata">=</stringProp>
</elementProp>
Expand Down Expand Up @@ -1327,6 +1336,7 @@ if(prev.getSamplerData().indexOf(textToCheck) &lt; 0) {
<collectionProp name="Arguments.arguments">
<elementProp name="" elementType="HTTPArgument">
<boolProp name="HTTPArgument.always_encode">false</boolProp>
<boolProp name="HTTPArgument.enabled_from_gui">true</boolProp>
<stringProp name="Argument.value">Body of Put</stringProp>
<stringProp name="Argument.metadata">=</stringProp>
</elementProp>
Expand Down Expand Up @@ -1410,6 +1420,7 @@ if(prev.getSamplerData().indexOf(textToCheck) &lt; 0) {
<collectionProp name="Arguments.arguments">
<elementProp name="name1" elementType="HTTPArgument">
<boolProp name="HTTPArgument.always_encode">false</boolProp>
<boolProp name="HTTPArgument.enabled_from_gui">true</boolProp>
<stringProp name="Argument.value">value1</stringProp>
<stringProp name="Argument.metadata">=</stringProp>
<boolProp name="HTTPArgument.use_equals">true</boolProp>
Expand Down Expand Up @@ -1491,6 +1502,7 @@ if(prev.getSamplerData().indexOf(textToCheck) &lt; 0) {
<collectionProp name="Arguments.arguments">
<elementProp name="name1" elementType="HTTPArgument">
<boolProp name="HTTPArgument.always_encode">false</boolProp>
<boolProp name="HTTPArgument.enabled_from_gui">true</boolProp>
<stringProp name="Argument.value">value1</stringProp>
<stringProp name="Argument.metadata">=</stringProp>
<boolProp name="HTTPArgument.use_equals">true</boolProp>
Expand Down
Loading
Loading