Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same spelling sampleResult in all dynamic samplers, functions, assertions and listeners #6369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FSchumacher
Copy link
Contributor

Description

Harmonize the spelling of the SampleResult variables used in scripting components.

Motivation and Context

In scripting listeners, assertions functions and samplers the SampleResult object is often given in the the scripting context via a variable. That variable should have the same name in all those components. This PR uses the spelling sampleResult in favour of SampleResult, as the variable points to an instance and in Java instances are named starting with a lowercase character.

This issue has been described in #6368.

One could argue to use the old name SampleResult as it might be found in more existing test cases.

As the next version of JMeter will be a major version, we could use this to deprecate the old writing and remove those in a later major version.

How Has This Been Tested?

Test cases have been adapted to use the new and old spelling.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.

Copy link
Collaborator

@vlsi vlsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, I am afraid we have to support the old spelling for quite some time (e.g. 5+years) so we do not break users's scripts.

@FSchumacher
Copy link
Contributor Author

LGTM. However, I am afraid we have to support the old spelling for quite some time (e.g. 5+years) so we do not break users's scripts.

Yes, we will have to support both spellings for a long time. But I always dream, that we could deprecate and remove some stuff :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants