Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripping success result in order to speed up transmit in distributed test mode #6410

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

junyejiang
Copy link
Contributor

@junyejiang junyejiang commented Jan 13, 2025

Stripping success result in order to speed up transmit in distributed test mode

Description

If the result is successful, fulfill SIZE information in BODY/HEADER etc, and replace DATA information with NULL. So the result could be smaller than it was.

Motivation and Context

When doing test in distributed mode, each Server will send its result back to Client. If the result size is big and the number of results is big too, it will take time to finish results transmission. Even we find that sometimes when test has already finished, STOP singal has been sent from Client to Servers, both Client and Servers cannot exit because result transmission was still undergoing whitch bocked Client and Servers from exting.
If a test result is FAILED, we do need its complete DATA information to do debug after test, we will not strip the result itself. But on the other hand, if a test result is SUCCESSFUL, we need only its SIZE to do static after test, we can trim all the DATA from BODY/HEADER etc.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.

@junyejiang
Copy link
Contributor Author

Do we save much by excluding dataType, dataEncoding? What if the server part uses data type, encoding, url, and so in via post-processor?

Do we save much by excluding dataType, dataEncoding? What if the server part uses data type, encoding, url, and so in via post-processor?

My previous thinking was that ‘if you want to shrink, you should shrink to a minimum'.
But you are right, the most size lies in body and header.
Updated as CR.

@junyejiang junyejiang requested a review from vlsi February 10, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants