Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV文件中共享模式汉化翻译有误:所有现场-->所有线程 #702

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

KING76169835
Copy link
Contributor

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.

@FSchumacher
Copy link
Contributor

While I don't speak Chinese, checking with translate on google seems to indicate it is a better translation (all threads instead of all sites).

@KING76169835
Copy link
Contributor Author

While I don't speak Chinese, checking with translate on google seems to indicate it is a better translation (all threads instead of all sites).

OK,I mean the Chinese translation, with a misspelling.
file path is "src/components/src/main/resources/org/apache/jmeter/config/CSVDataSetResources_zh_CN.properties"
param name is "shareMode.all"

@FSchumacher
Copy link
Contributor

While I don't speak Chinese, checking with translate on google seems to indicate it is a better translation (all threads instead of all sites).

OK,I mean the Chinese translation, with a misspelling. file path is "src/components/src/main/resources/org/apache/jmeter/config/CSVDataSetResources_zh_CN.properties" param name is "shareMode.all"

Sorry for the confusion. I meant, that the patch provides a better translation than the current one in trunk (at least according to google translate). So, this could be merged.

@FSchumacher FSchumacher merged commit 1d57315 into apache:master Feb 28, 2022
@KING76169835 KING76169835 deleted the Chinese_translate_bug_fix branch March 1, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants