KAFKA-12442: Upgrade ZSTD JNI from 1.4.8-4 to 1.4.9-1#10285
Merged
chia7712 merged 1 commit intoapache:trunkfrom Mar 12, 2021
dongjoon-hyun:KAFKA-12442
Merged
KAFKA-12442: Upgrade ZSTD JNI from 1.4.8-4 to 1.4.9-1#10285chia7712 merged 1 commit intoapache:trunkfrom dongjoon-hyun:KAFKA-12442
chia7712 merged 1 commit intoapache:trunkfrom
dongjoon-hyun:KAFKA-12442
Conversation
Contributor
|
@dongjoon-hyun Hi Hyun, it looks good to me. I love this update. 😄 |
dongjinleekr
approved these changes
Mar 10, 2021
chia7712
approved these changes
Mar 10, 2021
Member
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
@dongjoon-hyun thanks for your patch. No obvious performance regression from performance test (benchmark_test.py). +1
Member
Author
|
Thank you, @chia7712 and @dongjinleekr . |
Member
Author
|
Hi, @ijuma . Could you review this PR please? |
ijuma
approved these changes
Mar 11, 2021
Member
ijuma
left a comment
ijuma
left a comment
There was a problem hiding this comment.
LGTM. To be clear, there is no benefit from this change right now?
Member
Author
|
Since the new features are not used, you may right. However, I believe the benefits are three-fold.
|
Member
|
Sounds good. |
Member
Author
|
Thank you, @ijuma . |
Member
Author
|
Thank you for review and merging, @chia7712 and all! |
Member
|
@chia7712 worth cherry-picking to |
Member
done! |
chia7712
pushed a commit
that referenced
this pull request
Mar 13, 2021
Since the new features are not used, you may right. However, I believe the benefits are three-fold. - There exists ZSTD side bug-fixes at ZSTD 1.4.9. - There exists ZSTD JNI side memory optimization improvements at ZSTD JNI 1.4.8-5 ~ 1.4.8-7. (This includes some incompatible changes and recovery. So, 1.4.9 is more human-readable stable version number.). - I hope this will reduce the chance of future potential version conflict issues across Apache projects. It's important when some downstream project starts to use new feature. - Apache Spark 3.2.0 will use ZSTD 1.4.9. (apache/spark@ba7e525) - Apache Parquet 1.12.0 will use ZSTD 1.4.9 (apache/parquet-java@66ac28c) - Apache Avro 1.10.3 will use ZSTD 1.4.9 (apache/avro@806667c) Reviewers: Lee Dongjin <dongjin@apache.org>, Ismael Juma <ismael@juma.me.uk>, Chia-Ping Tsai <chia7712@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to upgrade ZSTD JNI from 1.4.8-4 to 1.4.9-1.
`ZStandard 1.4.9 and its corresponding JNI brings the following bug fixes and improvements.
One of notable improvement of ZStandard 1.4.9 is 2x faster Long Distance Mode, but we are not using it yet.
Since this is a dependency change, this should pass all the existing CIs.
Committer Checklist (excluded from commit message)