KAFKA-12609: Rewrite ListOffsets using AdminApiDriver #10467
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dengziming
changed the title
dengziming
force-pushed
the
new-list-offsets
branch
3 times, most recently
from
ee67f59 to
35475f6
Compare
3 tasks
dengziming
force-pushed
the
new-list-offsets
branch
from
35475f6 to
489220e
Compare
Member
Author
|
Helli @dajac , are you interested in reviewing this PR, the current |
Member
|
@dengziming Sure. I have added it to my review backlog. |
3 tasks
dengziming
force-pushed
the
new-list-offsets
branch
2 times, most recently
from
9a3be0c to
d5c852e
Compare
Member
|
@dengziming Sorry for the delay on this one. I wanted to get #10760 merge first before tackling this one. Could you rebase your PR to include those changes? |
Member
Author
dengziming
force-pushed
the
new-list-offsets
branch
2 times, most recently
from
57e2942 to
f051942
Compare
dengziming
force-pushed
the
new-list-offsets
branch
2 times, most recently
from
6ec6301 to
10896eb
Compare
dengziming
force-pushed
the
new-list-offsets
branch
from
10896eb to
34634e4
Compare
added 2 commits
August 29, 2021 21:28
rebase on new code rewrite listoffsets using new class
dengziming
force-pushed
the
new-list-offsets
branch
from
34634e4 to
8cdaff3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More detailed description of your change
See here: #10275 (comment)
Summary of testing strategy (including rationale)
ListOffsetsHandlerKafkaAdminClientTestCommitter Checklist (excluded from commit message)