Skip to content

KAFKA-12701: Remove topicId from MetadataReq since it was not supported in 2.8.0#10576

Closed
dengziming wants to merge 1 commit intoapache:trunkfrom
dengziming:KAFKA-12701-metadata-req-remove-topicId
Closed

KAFKA-12701: Remove topicId from MetadataReq since it was not supported in 2.8.0#10576
dengziming wants to merge 1 commit intoapache:trunkfrom
dengziming:KAFKA-12701-metadata-req-remove-topicId

Conversation

@dengziming
Copy link
Member

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

#9622 add topicId in MetadataResponse and MetadataRequest, but describe topic using topicId is supported by #9769

sadly #9622 PR was merged but #9769 PR was held off, for more details: #9769 (comment)
I think this is a bug so we should fix this for 2.8.0.

This PR should be cherry-picked to 2.8.0.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@junrao
Copy link
Contributor

junrao commented Apr 21, 2021

@dengziming : We probably can't remove a field from an existing protocol without changing the version. Otherwise, the client will be confused on the exact protocol for a particular version. We could bump up the version (keeping all the fields the same) in 3.0 and implement the functionality for topicId there. For 2.8, we probably want to at least document in the protocol that topicId is not supported.

@jolshan
Copy link
Member

jolshan commented Apr 22, 2021

@dengziming. I just saw this, so I didn't realize you were working on this too. I should have paid better attention. I opened #10584

@dengziming
Copy link
Member Author

Thank you @junrao @jolshan , move to #10584

@dengziming dengziming closed this Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments