KAFKA-12701: Remove topicId from MetadataReq since it was not supported in 2.8.0#10576
Closed
dengziming wants to merge 1 commit intoapache:trunkfrom
Closed
KAFKA-12701: Remove topicId from MetadataReq since it was not supported in 2.8.0#10576dengziming wants to merge 1 commit intoapache:trunkfrom
dengziming wants to merge 1 commit intoapache:trunkfrom
Conversation
Contributor
|
@dengziming : We probably can't remove a field from an existing protocol without changing the version. Otherwise, the client will be confused on the exact protocol for a particular version. We could bump up the version (keeping all the fields the same) in 3.0 and implement the functionality for topicId there. For 2.8, we probably want to at least document in the protocol that topicId is not supported. |
Member
|
@dengziming. I just saw this, so I didn't realize you were working on this too. I should have paid better attention. I opened #10584 |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
#9622 add topicId in MetadataResponse and MetadataRequest, but describe topic using topicId is supported by #9769
sadly #9622 PR was merged but #9769 PR was held off, for more details: #9769 (comment)
I think this is a bug so we should fix this for 2.8.0.
This PR should be cherry-picked to 2.8.0.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)